SABS-Group-2-2021-22 / drug-discovery-game-app

ReactJS app
BSD 3-Clause "New" or "Revised" License
6 stars 1 forks source link

467 editing final molecule selection #470

Closed TomKWise closed 6 months ago

TomKWise commented 6 months ago

Edited the final molecule selection process in the analysis page. Now you can select your final compound from the assay data table, selector panel, on right, will scroll to corresponding compound, selecting it (highlighting container in red) and open the accordion, showing the molecule widget etc.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 22.22222% with 28 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@b29e158). Click here to learn what that means.

Files Patch % Lines
src/components/analysis/molecule_list.js 11.11% 8 Missing :warning:
src/components/docking/molecule_widget_docking.js 14.28% 6 Missing :warning:
src/components/analysis/molecule_widget.js 28.57% 5 Missing :warning:
src/components/analysis/AssayDataTable.js 33.33% 4 Missing :warning:
src/components/docking/molecule_list_docking.js 0.00% 4 Missing :warning:
src/components/analysis/accordion_analysis.js 66.66% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #470 +/- ## ======================================= Coverage ? 21.85% ======================================= Files ? 109 Lines ? 1318 Branches ? 0 ======================================= Hits ? 288 Misses ? 1030 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/SABS-Group-2-2021-22/drug-discovery-game-app/pull/470/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SABS-Group-2-2021-22) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/SABS-Group-2-2021-22/drug-discovery-game-app/pull/470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SABS-Group-2-2021-22) | `21.85% <22.22%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=SABS-Group-2-2021-22#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SanazKaz commented 6 months ago

Much clearer selection with the red. Collapsable looks really good! no crashing.