SABS-R3-Epidemiology / seirmo

This is a project to model the outbreak of an infectious disease with the SEIR model.
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

fix simulation callback and loading #87

Closed rccreswell closed 3 years ago

rccreswell commented 3 years ago

Can you check if this works? The problem seems to be a spurious output in the callback

codecov[bot] commented 3 years ago

Codecov Report

Merging #87 (4d9bebe) into main (ebeebc6) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #87   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          265       265           
=========================================
  Hits           265       265           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ebeebc6...4d9bebe. Read the comment docs.

rccreswell commented 3 years ago

I moved the "loading" from the callback to the app. Using a dcc loading animation may not be necessary at all, I think it depends on the speed of simulations on heroku.