search

SABS-R3-projects / PKPD

A simple, graphical pharmacokinetic-pharmacodynamic modelling solution
GNU General Public License v3.0
18 stars 2 forks source link

Model class to master #21

Closed simonmarchant closed 4 years ago

simonmarchant commented 4 years ago

Added model functionality and tests.

simonmarchant commented 4 years ago

Our unit tests are passing fine normally but when run on travis they can't find the mmt file. The filepath is relative so it seems like the travis VM is running unittest fro a different directory or something. Does anyone have any ideas for us? @Rebecca-Rumney @DavAug

simonmarchant commented 4 years ago

@MichaelClerx we're having problems with the Travis builds failing to set-up myokit, could you give us a pointer please?

Commit 09adc71 failed Travis tests and we think it was because Travis couldn't find CVODE (full output: https://travis-ci.org/SABS-R3-projects/PKPD/jobs/624178227 ) which looks like it comes from sundials, so we tried to add libsundials-dev to the requirements in the setup.py (commit c9029d9) but pip can't find libsundials-dev. We've been banging our heads against a wall for ages and this seems like something that you might know off the top of your head, so: any ideas?

MichaelClerx commented 4 years ago

pip can only do python packages, you need to use apt-get to install sundials. I do it like this:

https://github.com/MichaelClerx/myokit/blob/master/.travis.yml#L72

simonmarchant commented 4 years ago

pip can only do python packages, you need to use apt-get to install sundials. I do it like this:

https://github.com/MichaelClerx/myokit/blob/master/.travis.yml#L72

Thankyou very much @MichaelClerx I feel like an ~idiot~ academic now ~:confused:~ :man_student:

MichaelClerx commented 4 years ago

Fixed that for you :D