SACGF / variantgrid

VariantGrid public repo
Other
23 stars 2 forks source link

Simplify HGVS errors in search #1113

Open davmlaw opened 3 months ago

davmlaw commented 3 months ago

Some HGVS errors are due to user input, some are due to implementation issues

For implementation details, that the user can do nothing about, we should just give a simplified error like "Cannot resolve HGVS"

We can separate this for admin/non admin

For non-admin examples of well formed HGVS that fail and they can do nothing about, eg:

NM_001145022.1:c.731C>T - This transcript exists, but we don't have it, or any versions for it - so will just sent to ClinGen and get back

Could not convert "NM_001145022:c.731C>T" - tried:
CLINGEN_ALLELE_REGISTRY as "NM_001145022.1:c.731C>T"

Some examples of bad HGVS that should be reported are:

See examples from #830

davmlaw commented 2 months ago

Have tried to go through and make all user errors appear, but I have probably missed some, happy to fix any examples you find