search

SACGF / variantgrid

VariantGrid public repo
Other
23 stars 2 forks source link

PDB link broken on classification page #160

Closed sksmi closed 3 years ago

sksmi commented 3 years ago

https://variantgrid.com/classification/classification/1735 https://www.rcsb.org/pdb/protein/P82914 image.png

TheMadBug commented 3 years ago

@sksmi to confirm for P82914 would https://www.rcsb.org/uniprot/P82914 be appropriate

and for P82914 would https://www.rcsb.org/uniprot/P82914 be appropriate?

(You have to wait a second or two on those pages for the data to load)

sksmi commented 3 years ago

@TheMadBug Yes, think that's the new page. Another example for BRCA1 is https://www.rcsb.org/uniprot/P38398

Option also to remove the link - the new format isn't as great for what we're doing - hard to see the sequence & access the models. Really only applicable to research & they can access via uniprot.

Still need a link to a good protein viewer linking genomic sequence to domain e.g. protein paint or similar - ideally this would be the VG hotspot graph, but lots of work to implement & maintain so not sure if feasible.

TheMadBug commented 3 years ago

For now I'm just fixing the link, happy to point it to something better (internally or externally) when it comes along.

sksmi commented 3 years ago

Tested on a couple of gene. All good.

EmmaTudini commented 3 years ago

@sksmi would it be ok if we reopened this so that I have it around for my next round of testing?

sksmi commented 3 years ago

@EmmaTudini done - all yours.

EmmaTudini commented 3 years ago

Testing:

Expected output: Would be taken to PDB page for Uniprot ID

Actual output: Passed