SACGF / variantgrid

VariantGrid public repo
Other
23 stars 2 forks source link

Discussion / planning for ACMG changes - population weighting (PM2), bayesian framework #691

Closed davmlaw closed 2 years ago

davmlaw commented 2 years ago

Need to think about (and maybe report back to SA Path) the difficulty of implementing 2 changes. Let James know and maybe he can have a quick think / discuss etc

SA Path do NOT want to switch to these yet, but are waiting for new ACMG guidelines update, word on the street is they will be released soon

How would it be done and should you be able to toggle it on or off? Ie settings or lab/system wide config?

TheMadBug commented 2 years ago

Currently the ACMG calculation is just a bit of JavaScript made as a suggestion to the user. Does the ACMG Bayesian framework still have all the same evidence keys? In which case that would be one of the smaller changes.

Re PM2 strength, it's almost as if the grid needs a rule engine. Interestingly enough that's what the report ended up doing - there's a lot of validation and warnings there. (Though again that's just JavaScript and doesn't have any influence on the data).

davmlaw commented 2 years ago

All you'd have to do with PM2 is change the weight, same calculation.

Then for the Bayesian framework, it's just using a different formula

They even provide a little spreadsheet you could copy the formula from:

TheMadBug commented 2 years ago

Surely for the PM2 change, the answer isn't to treat PM2 = moderate as supporting, but to actually change the values of PM2 = moderate to supporting?

Re the Bayesian framework, it looks like all the criteria are the same and the values for the criteria too (unless I'm missing something) - so most likely I'd actually just give the calculations based on both formulaes.

EmmaTudini commented 2 years ago

James has already implemented the points system (Bayesian model) in an export as that's what I ended up using for calculations in the paper. I specifically did an analysis of how many classifications would change if applying PM2 at a supporting weight instead of a moderate weight for all variants in Shariant.

@davmlaw What is SA Path wanting here? An estimation of how many classifications will change or a code change to change every instance of PM2 to PM2_supporting?

davmlaw commented 2 years ago

We're speccing out how much the change would affect us, so both development time and changing classifications.

EmmaTudini commented 2 years ago

Sent it to you. Just from the Shariant paper so not SA path specific but might give some guidance. It was also super easy to calculate. I just did it in excel.

davmlaw commented 2 years ago

Thanks a lot, this is enough for now I think - looks like we don't have to worry should be an easy change when / if we do it