search

SACGF / variantgrid

VariantGrid public repo
Other
23 stars 2 forks source link

Classification grid search - smart search box / filter by amino acid change #761

Open davmlaw opened 1 year ago

davmlaw commented 1 year ago

A user requested that they can search classification grid by the amino acid variant.

I think this only makes sense on the gene page as it doesn't make sense to bring up 2 classifications in different genes in the grid that happen to have the same AA change

There is a bit of complexity here as the HGVS listed is against the classified transcript which can vary. Thus you probably want to search all transcripts for that change

Raised meeting flag to decide if we should do this

davmlaw commented 1 year ago

In Shariant there is a mix of single and multi-character p.HGVS which could complicate this. There is an issue for normalizing that (do on ImportedAllele)

James mentions that there are too many boxes and by the time you add this, you may want to have just a plain text entry box that is a smart search across different fields (ie HGVS search or gene symbol etc)

GracePendlebury commented 1 year ago

Per SACGF/variantgrid_private#3440, can look at filter box alignment across browsers/systems after improvements.

davmlaw commented 1 year ago

While here - if we can look into lab multiple select (added in https://github.com/SACGF/variantgrid_private/issues/3289) looks bad when it has multiple options selected (as it spills over the grid)