Make Tests work on windows

SAFE-Stack / SAFE-template

dotnet CLI template for SAFE project

MIT License

282 stars 88 forks source link

Make Tests work on windows #426

Closed olivercoad closed 3 years ago

olivercoad commented 3 years ago

There were two issues preventing tests working on windows.

The first is pgrep, used for getting child process to kill the process tree. Fixed using wmic when on windows. The second is the path to npm. The fix code to locate it is copied from fake until we address #219

theimowski commented 3 years ago

Great thanks! Would be awesome to get these running on Travis Windows matrix, but last time I checked Travis C# didn't support windows

olivercoad commented 3 years ago

Don't really have experience with travis so not sure how the language support works. Could windows install dotnet 5 with chocolatey maybe?

theimowski commented 3 years ago

We're using community C# travis support and it seems it doesn't work with windows out of the box. Not sure how much effort is required to set something like this up.