search

SAFE-Stack / SAFE-template

dotnet CLI template for SAFE project
MIT License
282 stars 88 forks source link

Pinned TypeShape version to 8.0.1 to fix deployment issue #434

Closed Akash-Mair closed 3 years ago

Akash-Mair commented 3 years ago

Running an azure deployment would break since a different version of TypeShape was being used (9.0.0)

For more details - https://github.com/Zaid-Ajaj/Fable.Remoting/issues/226

theimowski commented 3 years ago

a08bd5b updates Fable.Remoting.Server to latest and removes transitive TypeShape dependency (see https://github.com/Zaid-Ajaj/Fable.Remoting/commit/42bfab7f208e979fb55a1fe6b643d930913fe3f2)

isaacabraham commented 3 years ago

I think we can close this PR without merging?

Zaid-Ajaj commented 3 years ago

Yeah Fable.Remoting no longer requires TypeShape as a nuget dependency