search

SAFE-Stack / SAFE-template

dotnet CLI template for SAFE project
MIT License
282 stars 88 forks source link

Safe apps have npm dependencies missing / out of date #455

Closed teknikal-wizard closed 1 year ago

teknikal-wizard commented 3 years ago

I just installed a package with Femto, and it bumped my React version to 17.x (from 16.x in the default app) and also imported bulma.

It looks like bulma is being pulled in because Fulma is still in the paket dependencies file. We could just remove it now that we use Feliz.Bulma (which doesn't require bulma at all).

React is being bumped because of Feliz I believe.

Nhowka commented 3 years ago

Feliz.Bulma has bulma added as a requirement for Femto.

teknikal-wizard commented 3 years ago

Ah so it does. It's a bit confusing as the template doesn't come with Bulma but it still seems to work?

Either way, I would think it is a good idea to release a template update after running Femto on it.

Nhowka commented 3 years ago

The template kinda cheats and gets it from a CDN, that's why it don't appear to be a dependency. Check here

teknikal-wizard commented 3 years ago

ahhhh

isaacabraham commented 3 years ago

What's the best way forward here - should we be including it again as a dependency? A couple of of the reasons we removed it was:

  1. Cut down on bundle size.
  2. Ensure we kept the webpack stuff as simple as possible.
teknikal-wizard commented 1 year ago

@isaacabraham just doing the clean up - I'll close this for now as the current template uses React 17. The Bulma npm vs CDN issue can be reopened if there is interested.