SAFE-Stack / SAFE-template

dotnet CLI template for SAFE project
MIT License
282 stars 88 forks source link

Upgrade to Chockidar 3 #462

Closed isaacabraham closed 2 years ago

isaacabraham commented 3 years ago

Building a SAFE v3 project currently gives the following:

chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.

I got stung by this recently. People that have newer versions of node will simply get a crappy error message on first time they use SAFE.

theimowski commented 3 years ago

I still can't get my head around npm dependencies - we actually have chokidar pinned to version 3.5.1. I assume that this warning comes from one of the transient dependencies - e.g. webpack -> watchpack -> watchpack-chokidar2 -> chokidar ^2.1.8 Not sure if one can mute such warnings given that we already use newer version, or whether the only solution is to update webpack family to version 5

... or remove webpack altogether

isaacabraham commented 3 years ago

Was Chokidar always pinned? Let me test this again with newer Node - maybe I had an older version of the template running.

isaacabraham commented 2 years ago

Fixed by #472