SAFE-Stack / SAFE-template

dotnet CLI template for SAFE project
MIT License
282 stars 87 forks source link

Remove font awesome from paket #471

Closed isaacabraham closed 3 years ago

isaacabraham commented 3 years ago

Fixes #456. If there's a way to use these libraries seamlessly with Feliz.Bulma, I'm happy for this not to go in and to add a recipe instead? cc @Dzoukr @Zaid-Ajaj

Dzoukr commented 3 years ago

I personally found Font Awesome too quickly evolving to have some strongly-typed API wrapping it so I just use an npm package or direct link to CDN.

isaacabraham commented 3 years ago

That's basically what the template does, aside from still include the NuGet package. As we've now moved over to Feliz.Bulma, I'm not sure what sense it makes to keep it.

theimowski commented 3 years ago

yeah let's get it removed - noticed there's a recipe in docs that has inconsistent instructions between default and minimal: https://github.com/SAFE-Stack/docs/blob/master/docs/recipes/ui/add-fontawesome.md#3-code-snippet