SAFE-Stack / SAFE-template

dotnet CLI template for SAFE project
MIT License
282 stars 87 forks source link

Temp fix - chokidar #486

Closed Akash-Mair closed 2 years ago

Akash-Mair commented 2 years ago

On the minimal template if you have a specific version of node(14.17.2/npm(7.19.1) you get the below error

throw new Error(
^

Error: No version of chokidar is available. Tried chokidar@2 and chokidar@3.
You could try to manually install any chokidar version.
chokidar@3: Error: Cannot find module 'chokidar'

But the full template is fine, this is because in the full template various dependencies (sass) use the latest version of chokidar and webpack is using 4.44.6

I've copied over the same versions of webpack/webpack-cli/webpack-dev-server from the full to the minimal as they should always be in sync and re made the lock file.

This has fixed the bug :)

Akash-Mair commented 2 years ago

@isaacabraham - I was able to confirm our fix from this afternoon. Let me know if you need anything else :)

isaacabraham commented 2 years ago

Fixes #462

isaacabraham commented 2 years ago

@theimowski you ok with this?

theimowski commented 2 years ago

Is this maybe fixed by #485?

teknikal-wizard commented 2 years ago

This is indeed fixed by the webpack update. I think the plan was to fast track in this fix whilst we work on getting #485 merged

theimowski commented 2 years ago

yeah I'd say let's get #485 to work, don't think we need to rush with this workaround

theimowski commented 2 years ago

can we close it now?

halcwb commented 2 years ago

The above problem is not resolved in 3.1.1 is this correct? Got it working upgrading webpack and copying dependencies from the latest package.json from the full safe-stack template.

isaacabraham commented 2 years ago

@halcwb Yes, that looks to be the case. @theimowski what's your thoughts on release e.g. SAFE 3.2 (or 3.5?) which upgrades this?

isaacabraham commented 2 years ago

I think we can close this now, especially since #485 has been merged in.

theimowski commented 2 years ago

yeah we should release new version soon (quite a few changes) but I think it makes sense to include .net 60 upgrade https://github.com/SAFE-Stack/SAFE-template/pull/494

isaacabraham commented 2 years ago

Fixed by #472