search

SAFE-Stack / SAFE-template

dotnet CLI template for SAFE project
MIT License
282 stars 87 forks source link

Update Fantomas to 4.6 #499

Closed nojaf closed 2 years ago

theimowski commented 2 years ago

Funny coincidence - I was just reviewing 4.6 release notes :) Any idea why all CI tasks failed with same error?

client: Bundling for production...
client: [webpack-cli] Failed to load '/home/travis/build/SAFE-Stack/SAFE-template/Content/default/webpack.config.js' config
client: [webpack-cli] TypeError: MiniCssExtractPlugin is not a constructor
client:     at Object.<anonymous> (/home/travis/build/SAFE-Stack/SAFE-template/Content/default/webpack.config.js:88:13)
...

master branch builds fine - as you changed only *.fs files I'd guess this could be related to some nasty spacing / line ending issue with Fable?

nojaf commented 2 years ago

Hmm, this feels very unrelated to be honest. I would need to take a closer look as I'm on my phone right now. Who still uses webpack though 😅

nojaf commented 2 years ago

Tried this locally, I get the exact same webpack error with the master branch as with this PR. I also noticed the package-lock.js is updated when I run dotnet run -- Bundle inside the default folder. I find this weird.

nojaf commented 2 years ago

Turns out my branch was out of sync 🙈

theimowski commented 2 years ago

cool, thanks!