search

SAFE-Stack / SAFE-template

dotnet CLI template for SAFE project
MIT License
282 stars 87 forks source link

Net6 + Saturn test #506

Closed teknikal-wizard closed 2 years ago

teknikal-wizard commented 2 years ago

This is just tico321 's PR with more deps updated including the latest Saturn preview pulled in, plus the dotnet tools bumped.

I mainly created it as I am trying to find out what is breaking the build pipeline and I'm not a maintainer so I needed my own branch to tweak and push. It can be absorbed back into the original PR once I have (hopefully) fixed it.

olivercoad commented 2 years ago

I think I found the issue.

https://github.com/CompositionalIT/SAFE-template/blob/6156f9bf287eabdeab02978cb4bef6fc7837e9f3/tests/Tests.fs#L151-L160

It is doing the dotnet run before the dotnet tool restore. Moving line 160 to 153 fixes it.

teknikal-wizard commented 2 years ago

@olivercoad Just pushing it up now to test, thanks!

teknikal-wizard commented 2 years ago

@olivercoad it passed, amazing, thank you :) Still seems odd that it worked locally and on the other build hosts.

olivercoad commented 2 years ago

Awesome! Yeah that's odd. I know these kinds of ci issues can sometimes take hours to diagnose, so glad it works now.

theimowski commented 2 years ago

Now this PR has just the azure check but it's missing the Travis ones 😞 need to figure out why that is

theimowski commented 2 years ago

Ok Travis now back, but don't know of a way to re-run it for this PR, so created a duplicate here #513 - once it turns green, I'm good with getting this merged and released. @isaacabraham you fine with that?

teknikal-wizard commented 2 years ago

Just updated Saturn to the full release (along with some other bits), so we have no preview dependencies now.

teknikal-wizard commented 2 years ago

Both pipelines seem to be happy as well.

isaacabraham commented 2 years ago

@theimowski i'm good with all this, let's do it.

cgravill commented 2 years ago

It'd be really helpful to get this merged and released. I've been demoing some use of SAFE that need Net6 and it confuses/worries folks new to SAFE having to give them an alternative install after showing the docs.

isaacabraham commented 2 years ago

@theimowski I'm going to merge this tomorrow unless I hear otherwise :-) Perhaps we can push a new release out next week?

theimowski commented 2 years ago

sure, go for it 👍 sorry last weeks were a bit hectic for me, I'm happy to share push access to nuget should you want to release it as well.

theimowski commented 2 years ago

Just released it in version 4.0.0