search

SAFE-Stack / SAFE-template

dotnet CLI template for SAFE project
MIT License
283 stars 87 forks source link

Move from fantomas-tool to fantomas #529

Closed isaacabraham closed 1 year ago

isaacabraham commented 2 years ago

With the imminent release of Fantomas 5, we should upgrade the dotnet-tools.json:

-"fantomas-tool": {
+"fantomas": {
-  "version": "4.7.1",
+  "version": "5.0.0",
  "commands": [
    "fantomas"
  ]
},

We also need to update .editorconfig as follows:

-[src/Client/*.fs]
-# Feliz style
-fsharp_single_argument_web_mode=true
+fsharp_multiline_block_brackets_on_same_column = true
+fsharp_experimental_stroustrup_style = true
isaacabraham commented 2 years ago

@nojaf is this roughly correct?

nojaf commented 2 years ago

Yes, that will do the trick.

On a side note: I would also advise to change insert_final_newline = false to true. See link

isaacabraham commented 2 years ago

Will do. Any reason why this isn't the default then? :-)

nojaf commented 2 years ago

It is the default in Fantomas, but the .editorconfig of the template seems to have put it on false.