search

SAFE-Stack / SAFE-template

dotnet CLI template for SAFE project
MIT License
280 stars 87 forks source link

Look at files in Client.fsproj that probably are not required to be #580

Closed martinbryant closed 7 months ago

martinbryant commented 7 months ago

The following files are noted in the Client.fsproj that are dev/build specific and do not affect the building of the Client project.

We should look to get input from @MangelMaxime about this and if we can remove them if there is no reason to leave them

MangelMaxime commented 7 months ago

Hello,

Fable only needs the .fs files to be include in the project file.

Adding others files likes:

        <None Include="postcss.config.js" />
        <None Include="tailwind.config.js" />
        <None Include="index.html" />
        <None Include="paket.references" />

Is a matter of preference.

Personally, because I never use the Solution Explorer view, I never add this files in my project files. But I know people who use Solution Explorer instead of File Explorer, includes this files so they can have an easy access to them.

The decision on this subject, depends on how you think people will consume the template and use it.

theprash commented 7 months ago

These are there because I am intentionally including them to make the files easily available in Visual Studio. Is there some reason to remove them?

martinbryant commented 7 months ago

No I was just checking out why they were there so if they are useful to you as a VS user we need to make sure all of the additional files added are included in their respective proj files.

Personally I do not use VS and everything builds and runs without the need for this.

On Thu, 7 Dec 2023 at 14:13, Prash @.***> wrote:

These are there because I am intentionally including them to make the files easily available in Visual Studio. Is there some reason to remove them?

— Reply to this email directly, view it on GitHub https://github.com/SAFE-Stack/SAFE-template/issues/580#issuecomment-1845415084, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGBII5IY2RWV7H2LLD6Y5WLYIHFJRAVCNFSM6AAAAABADFCRR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGQYTKMBYGQ . You are receiving this because you authored the thread.Message ID: @.***>

RicoSaupe commented 7 months ago

I use rider a lot and also there it's quite useful. I have a pull request open for that so I could check the project files again.

RicoSaupe commented 7 months ago

Updated the proj and sln files in my pr. Please have a look and approve.