search

SAFE-Stack / SAFE-template

dotnet CLI template for SAFE project
MIT License
280 stars 87 forks source link

updated sln reference, readme #582

Closed RicoSaupe closed 7 months ago

RicoSaupe commented 7 months ago

first small PR. :)

in regards to issue #580 i discovered also the following.

  1. webpack config was still in default sln file
  2. travis.yml still referenced net 6
  3. updated readme.md files to reflect used net8 and updated npm, node versions
RicoSaupe commented 7 months ago

Another thought. Do we need to reference these file as solution files? They are generated anyways and not to be edited or is someone changing them?

package-lock.json paket.lock

These files, imho, make more sense to me.

grafik

isaacabraham commented 7 months ago

@martinbryant these changes look good, especially the readme.md which is critical to get correct - it's the docs file that everyone looks at the first time.

RicoSaupe commented 7 months ago

@isaacabraham was aligning the project file names to start upper case but if failed here "tests/tests.fsproj". I could rename the file and also the references to it but git ignored the upper lower case file name and did not push the file name change. So you build failed, since its using ubuntu. Any idea how to push also the file name changes? If you think its ok.

martinbryant commented 7 months ago

@RicoSaupe thanks very much for the PR.

I have pushed some changes that fixed the file renaming. Its a bit silly that it doesn't recognise the case change so I committed a change to rename completely and then another to make it correct ;)

isaacabraham commented 7 months ago

Thank you both very much!