search

SAFE-eV / OCMF-Open-Charge-Metering-Format

24 stars 13 forks source link

Inconsistent Description in the Documentation for Loss Compensation #35

Open maba-evo opened 2 months ago

maba-evo commented 2 months ago

It looks like there is something like a typo which makes it quite hard to implement the Loss Compensation. The example file defines the LC property as follows:

...
 "LC": {
        "LN": "cable_name",
        "LI": 1,
        "LR": 2,
        "LU": "mOhm"
    },
...

In table 24 the LU property is defined as a required number, but the textual description defines the property as a string with either one of the two values "mOhm" or "uOhm".

I guess that the textual description is correct, but I am not 100% sure. And if my assumption is right does this property use the same values as defined in table 20 Units.

Thanks and kind regards.

mhei commented 1 month ago

Yes, I'm with you. Looks like a typo. I've created the referenced PR to fix it. It will be most probably discussed in the next OCMF UA meeting.