Closed p-j-smith closed 2 months ago
Attention: Patch coverage is 84.56376%
with 23 lines
in your changes missing coverage. Please review.
Project coverage is 84.89%. Comparing base (
34cf403
) to head (b84c826
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It looks good to me. I wonder if it is useful to add some details or links in relevant README files on how to connect to xnat (which might solve few of my comments?).
Thanks for the review! Yeah good point, I'll add some info on how to connect to XNAT and login
Thanks for the reviews, and for making sure the tests run properly!
Description
Fixes #471
core.uploader._orthanc.StudyTags
to hold relevant info for a study to be uploadedcore.uploader._xnat.XNATUploader
to upload a zipped DICOM study to XNAT using XNATPyType of change
Please delete options accordingly to the description.
Suggested Checklist
main
branch.UCLH-Foundtry/arc-dev
squash and merge
Here's the scans uploaded to XNAT by the test: