SAFEHR-data / PIXL

PIXL Image eXtraction Laboratory
Apache License 2.0
8 stars 0 forks source link

Add XNAT as an endpoint #483

Closed p-j-smith closed 2 months ago

p-j-smith commented 3 months ago

Description

Fixes #471

Type of change

Please delete options accordingly to the description.

Suggested Checklist

Here's the scans uploaded to XNAT by the test:

xnat-with-test-data
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 84.56376% with 23 lines in your changes missing coverage. Please review.

Project coverage is 84.89%. Comparing base (34cf403) to head (b84c826). Report is 1 commits behind head on main.

Files Patch % Lines
pixl_core/src/core/uploader/_xnat.py 53.12% 15 Missing :warning:
pixl_core/src/core/uploader/_ftps.py 0.00% 2 Missing :warning:
pixl_core/tests/uploader/test_xnat.py 97.10% 2 Missing :warning:
pixl_core/src/core/uploader/_dicomweb.py 66.66% 1 Missing :warning:
pixl_core/src/core/uploader/_orthanc.py 87.50% 1 Missing :warning:
pixl_core/src/core/uploader/base.py 90.90% 1 Missing :warning:
pixl_export/src/pixl_export/main.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #483 +/- ## ========================================== + Coverage 83.31% 84.89% +1.57% ========================================== Files 80 86 +6 Lines 3374 3753 +379 ========================================== + Hits 2811 3186 +375 - Misses 563 567 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

p-j-smith commented 3 months ago

It looks good to me. I wonder if it is useful to add some details or links in relevant README files on how to connect to xnat (which might solve few of my comments?).

Thanks for the review! Yeah good point, I'll add some info on how to connect to XNAT and login

p-j-smith commented 2 months ago

Thanks for the reviews, and for making sure the tests run properly!