SAFEHR-data / PIXL

PIXL Image eXtraction Laboratory
Apache License 2.0
8 stars 0 forks source link

Orthanc Raw modifies `StudyInstanceUID`, `SeriesInstanceUID`, and `SOPInstanceUID` when modifying the study project name tag` #496

Closed p-j-smith closed 2 months ago

p-j-smith commented 2 months ago

I might be doing something wrong but I think the StudyInstanceUID, and SeriesInstanceUID, and SOPInstanceUID values are modified by Orthanc Raw when retrieving data from the archives, which means we can't compare SOPInstanceUIDs to check for existing instances. I'll open a PR with a test to check the StudyInstanceUID in Orthanc Raw is the same as in the VNA (assuming this is the expected behaviour?)

Originally posted by @p-j-smith in https://github.com/SAFEHR-data/PIXL/issues/486#issuecomment-2326050577

p-j-smith commented 2 months ago

The UIDs are modified when setting the private tag (see this thread for further info).

I think we will need to use the Force and Keep arguments to the modify endpoint to ensure the UIDs are not changed.