482 - Added configurations for default de-identification of IoN-DRI MRI projects

mxochicale commented 2 months ago

Description

Fixes #482, I am starting this PR to initiate review, including:

projects/configs/tag-operations/mri.yaml (with Study date op: "replace")
projects/configs/tag-operations/base.yaml (currently a copy of mrl.yaml)

Notes

[x] Once https://github.com/SAFEHR-data/PIXL/pull/493 is resolved this one will be rebased!

Type of change

Please delete options accordingly to the description.

[x] New feature (non-breaking change which adds functionality)

Suggested Checklist

[x] I have performed a self-review of my own code.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have passed on my local host device. (see further details at the CONTRIBUTING document)
[x] Make sure your branch is up-to-date with main branch. See CONTRIBUTING for a general example to syncronise your branch with the main branch.
[x] I have requested PR review to UCLH-Foundtry/arc-dev
[x] I have adddressed and marked as resolved all the review comments in my PR.
[x] Finally, I have selected squash and merge

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.08%. Comparing base (b5bd40b) to head (57af5ec). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pixl_dcmd/tests/test_tag_schemes.py	88.88%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #498 +/- ## ======================================= Coverage 86.08% 86.08% ======================================= Files 86 86 Lines 4075 4083 +8 ======================================= + Hits 3508 3515 +7 - Misses 567 568 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mxochicale commented 2 months ago

Thank Stef for your feedback. Our Thursday stand up was helpful in clarifying the relevant modalities for the base configuration file. Please let me know if you have any further feedback :vulcan_salute:

mxochicale commented 2 months ago

Thanks Stef Please take a look at the changes. I believe the base already includes tags for shared modalities, moved relevant tags to mri config file, and added X-ray config file.

mxochicale commented 1 month ago

Thanks Stef, just added few commented lines to document config file requirements. Let me know if you have further comments, otherwise I will merge this one before the end of the day!

SAFEHR-data / PIXL