SAFEHR-data / PIXL

PIXL Image eXtraction Laboratory
Apache License 2.0
8 stars 0 forks source link

388 - Adding coverage to pytest-pixl #501

Closed mxochicale closed 1 month ago

mxochicale commented 2 months ago

Description

Fixes #388: Adding coverage to pytest-pixl, including the following tests to cover _create_default_json and FtpHostAddress:

See report in codecov

Type of change

Please delete options accordingly to the description.

Suggested Checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.37%. Comparing base (7ae5a68) to head (f573520). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #501 +/- ## ========================================== + Coverage 86.08% 87.37% +1.28% ========================================== Files 86 76 -10 Lines 4083 3367 -716 ========================================== - Hits 3515 2942 -573 + Misses 568 425 -143 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mxochicale commented 1 month ago

Hi, this is a good start for covering pytest-pixl. Just requesting your review. Thanks, Miguel.

mxochicale commented 1 month ago

Thanks Stef, let me know your thoughts! Coverage report for dicom.py, ftpserver.py, and plugin.py seem to be >90%. I am not sure if we would like dive in to address the uncovered parts of helpers.