search

SAI990323 / TALLRec

Apache License 2.0
213 stars 32 forks source link

🐛 Please fix this typo error. #1

Closed tsotfsk closed 1 year ago

tsotfsk commented 1 year ago

https://github.com/SAI990323/TALLRec/blob/5d978b13d3563f02e726f5c9ee1c372477e2970e/evaluate.py#L180

I noticed that there is a line at the end of the prompt that reads # noqa: E501. While I understand that this is added to suppress the PEP 8 error related to line length. I believe it would be better to remove it.

SAI990323 commented 1 year ago

Thank you for your advice. Actually, we have found these characters before. However, since this repository is forked from alpaca-lora, at the time we forked, its code contained such characters, but we did not know the specific function of this character. We have tested that there is no significant difference between deleting and not deleting the string, so we did not adjust it. Now we find the characters have been removed from the alpaca-lora, and we will remove it also.