SAIC-iSmart-API / saic-home-assistant-addon

SAIC-iSmart-API repository for Home Assistant OS (HASS.IO)
MIT License
57 stars 6 forks source link

Unavailable Values now #81

Closed coolrunning5360 closed 5 months ago

coolrunning5360 commented 5 months ago

It’s not good if the car currently has no reception and all values are displayed as unavailable. Additionally, the last known values should be shown.

nanomad commented 5 months ago

While I see your point, the last values are still retained by HA and the decision has been made to reflect the true state of the car in HA. We don't know the value of the sensors since we don't know what happened since the last error.

We can expose a config option (disabled by default) not put sensors "unavaibile" if the car is offline and we tried to reach it, although please keep in mind that you won't know if a command got executed correctly or the values you are now seeing are true or not.

This causes automations and helpers (like utility meters) to subtly break, behave strangely or provide wrong values.

Also: sensors go "unavailable" only if we tried actively contacting the car and we couldn't.

coolrunning5360 commented 5 months ago

I understand the decision to do it the way it is now. However, my issue is that I have no reception at home, and everything always shows as ‘unavailable’ there. I think it would be better if, as soon as no query is possible, the last available data, for example, are displayed in red. Then you can see at a glance that it’s not the live data.

nanomad commented 5 months ago

We have no way of controlling that unfortunately (as far as I know). I'm going to add a HA_SHOW_UNAVAILABLE config settings, default to True.

You can switch that to False then rely on the "Last refresh" values to decide the color to use in the UI. I'll let you know as soon as there's a version you can test, in the meantime you can switch to the pre-release channel of the addon

coolrunning5360 commented 5 months ago

Oh, thank you very much. That would be great.

coolrunning5360 commented 5 months ago

Sorry, but how can I switch to Pre-release?I’m the in first week of Homeassistant and in GiHub 😂. Am 16.04.2024 um 20:50 schrieb Dennis Wehr @.***>: Closed #81 as completed via #82.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

nanomad commented 5 months ago

Just uninstall the current version of the add-on and re-install the one marked with (pre). I'm not an addon user so I cannot help much on that side

Il Mar 16 Apr 2024, 20:58 coolrunning5360 @.***> ha scritto:

Sorry, but how can I switch to Pre-release?I’m the in first week of Homeassistant and in GiHub 😂. Am 16.04.2024 um 20:50 schrieb Dennis Wehr @.***>: Closed #81 as completed via #82.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/SAIC-iSmart-API/saic-home-assistant-addon/issues/81#issuecomment-2059742128, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIT3RSFVN5NZMZFMPBIIYTY5VYGLAVCNFSM6AAAAABGJX27UWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZG42DEMJSHA . You are receiving this because you were assigned.Message ID: @.*** com>

coolrunning5360 commented 5 months ago

Ah ok Thanks Am 16.04.2024 um 21:01 schrieb Giovanni Condello @.***>: Just uninstall the current version of the add-on and re-install the one

marked with (pre). I'm not an addon user so I cannot help much on that side

Il Mar 16 Apr 2024, 20:58 coolrunning5360 @.***> ha

scritto:

Sorry, but how can I switch to Pre-release?I’m the in first week of

Homeassistant and in GiHub 😂. Am 16.04.2024 um 20:50 schrieb Dennis Wehr

@.***>:

Closed #81 as completed via #82.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are

receiving this because you authored the thread.Message ID: @.***>

Reply to this email directly, view it on GitHub

https://github.com/SAIC-iSmart-API/saic-home-assistant-addon/issues/81#issuecomment-2059742128,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/AAIT3RSFVN5NZMZFMPBIIYTY5VYGLAVCNFSM6AAAAABGJX27UWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZG42DEMJSHA

.

You are receiving this because you were assigned.Message ID:

@.***

com>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Tonno87 commented 5 months ago

The new version doesn't work, the gateway crashes while initial startup. But home assistant doesn't save addon logs...

nanomad commented 5 months ago

I'll check :)

On Tue, 16 Apr 2024 at 21:59, Dennis Wehr @.***> wrote:

The new version doesn't work, the gateway crashes while initial startup. But home assistant doesn't save addon logs...

— Reply to this email directly, view it on GitHub https://github.com/SAIC-iSmart-API/saic-home-assistant-addon/issues/81#issuecomment-2059829487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIT3RUIE64TWSOCV4XOU63Y5V7KXAVCNFSM6AAAAABGJX27UWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJZHAZDSNBYG4 . You are receiving this because you were assigned.Message ID: @.*** com>

nanomad commented 5 months ago

@Tonno87 RC2 is out, seems to be working OK here

@coolrunning5360 If you go to the “Add-on” page, on the top right there's a button to force refresh the list of updates, it should pick up the update to 0.6.1-rc2

coolrunning5360 commented 5 months ago

I can test it tomorrow, thxAm 16.04.2024 um 22:34 schrieb Giovanni Condello @.***>: @Tonno87 RC2 is out, seems to be working OK here @coolrunning5360 If you go to the “Add-on” page, on the top right there's a button to force refresh the list of updates, it should pick up the update to 0.6.1-rc2

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

coolrunning5360 commented 5 months ago

I have Test it. This Version with the Setting works now for me.

nanomad commented 5 months ago

Nice, you can keep the config as is. Eventually it will be released to the stable branch as well