SAIC-iSmart-API / saic-python-client-ng

MIT License
3 stars 2 forks source link

First Release #1

Closed nanomad closed 8 months ago

nanomad commented 8 months ago

The current version, as it stands, is ready for its first release.

tosate commented 8 months ago

Hi @nanomad

I have seen that you have opened a pull request in the MQTT gateway. You have mentioned that it's blocked by this issue. Do you want me to merge the pull request or is there something I need to wait for?

How do we proceed?

nanomad commented 8 months ago

The MQTT gateway requires a first release of this library. I did run some tests with another user and the current version is working fine. It has feature parity with the old library, bugs included.

It needs to be released on pypi so that it can be pulled in as a dependency. I've never done that, so I'll leave that to you :)

tosate commented 8 months ago

Okay, I have a busy day ahead of me. I'll try to take care of it on Tuesday or Wednesday.

nanomad commented 8 months ago

No worries, I'll test the gateway in the next couple of weeks. The old one works just fine so we are in no rush

tosate commented 8 months ago

Hi @nanomad,

I see that you have the python-publish.yml that specifies the GitHub workflow and you have pyproject.toml project file. If we want to publish the NG client und my pypi account, we would have to put my API key as a secret in the project settings. I cannot do that and I cannot create a release of the library.

nanomad commented 8 months ago

Uhm I don't have admin rights either, I guess it's not under the python group so the admin rights go straight to @tisoft ?

tosate commented 8 months ago

I have tried to add the repoisory to the Python team: You do not have sufficient permissions to add the saic-python-client-ng repository to this team

@tisoft can you have a look, please?

tisoft commented 8 months ago

I think I have added it to the python team. Please try again.

tosate commented 8 months ago

The repository belongs to the Python team now. Thank you @tisoft I have the maintainer role. However, I don't have the permission to define secrets for actions. Only administrators can do that.

tisoft commented 8 months ago

@tosate You should have admin permissions now

tosate commented 8 months ago

Thank you very much @tisoft

Release 0.0.1 has been published on PyPi