search

SAIC-iSmart-API / saic-python-mqtt-gateway

A service that queries the data from an MG iSMART account and publishes the data over MQTT and to other sources
MIT License
71 stars 21 forks source link

Add suffix to battery heating stop reason topic to allow discriminate it from battery heating topic #253

Closed pakozm closed 2 weeks ago

pakozm commented 2 months ago

I do not know exactly how to prepare this pull request, it is very simple.

pakozm commented 2 months ago

@nanomad This is a very simple fix, let me know if it can be integrated.

pakozm commented 2 months ago

@nanomad do you think this pull request can be added to master? Should I request it to develop branch?

pakozm commented 1 month ago

@nanomad do you think this pull request can be added to master? Should I request it to develop branch?

Perfect, I move it to develop

nanomad commented 1 month ago

Hi @pakozm I'm sorry but I don't understand the request, the topic is used to publish and react to new battery heating schedules. Can you point where the error reason is actually published to this topic?

pakozm commented 3 weeks ago

Hi @pakozm I'm sorry but I don't understand the request, the topic is used to publish and react to new battery heating schedules. Can you point where the error reason is actually published to this topic?

I'm sorry, I made a big mistake in the proposal. My purpose was to allow two different topics for the battery heating and the battery hearing stop reason. If not, the battery heating topic ends up with a weird "UNKNOWN (0)" or similar value, which is confusing. It should be, IMO, an ON or OFF value. So, having that value in the stop reason topic seems better, IMO.

I hope you find this time it much better.

nanomad commented 2 weeks ago

Ah of course!

That was a big oversight from my side