search

SAITARUN55 / metroapp

MIT License
11 stars 17 forks source link

Added Login via Gmail Feature #2 #23

Closed shivaniaakanksha closed 4 years ago

shivaniaakanksha commented 4 years ago

shifted to AndroidX Added Gmail Login Using Firebase.

shivaniaakanksha commented 4 years ago

shifted to AndroidX Added Gmail Login Using Firebase.

@SAITARUN55 https://github.com/SAITARUN55/metroapp/issues/2#issuecomment-603038068 Please Review.

shilpi1958 commented 4 years ago

@sakshivij are you still working on it?

sakshivij commented 4 years ago

@shilpi this issue most probably was taken by someone else and already done with. Changes have not been merged most probably

SAITARUN55 commented 4 years ago

@shilpi1958 This is pr...she has already taken and made changes and pushed it too...but there were issues while running the application

shivaniaakanksha commented 4 years ago

@SAITARUN55 can you please look into this and try to solve the conflicts as its too delayed now.

SAITARUN55 commented 4 years ago

@SAITARUN55 can you please look into this and try to solve the conflicts as its too delayed now.

mostly by tomorrow, I will

prasadsunny1 commented 4 years ago

I'll look into this and fix your PR @shivaniaakanksha

SAITARUN55 commented 4 years ago

@prasadsunny1 There is no JSON file and there are errors while running...she took the analytics from pubspec but there is a file related to analytics... I thought she will push the JSON but that also will be a problem for me if she does it...

SAITARUN55 commented 4 years ago

@prasadsunny1 There is no JSON file and there are errors while running...she took the analytics from pubspec but there is a file related to analytics... I thought she will push the JSON but that also will be a problem for me if she does it...

The problem while running is its about SDK version to upgrade whereas in her system it's running very effectively, but I am unable to update the same in my system

shivaniaakanksha commented 4 years ago

@prasadsunny1 There is no JSON file and there are errors while running...she took the analytics from pubspec but there is a file related to analytics... I thought she will push the JSON but that also will be a problem for me if she does it...

I pushed the JSON file but it is in .gitignore , I have shared the files on slack.

prasadsunny1 commented 4 years ago

Add your own json file

prasadsunny1 commented 4 years ago

JSON should not be pushed into git

sakshivij commented 4 years ago

I tested the repo. The issue is something related to firebase analytics. Even though it has been removed. If it's fine I can work on this.. since I'm halfway done.

sakshivij commented 4 years ago

Or totally up to you guys as well. Depends on how you all want to take this.

shivaniaakanksha commented 4 years ago

@prasadsunny1 There is no JSON file and there are errors while running...she took the analytics from pubspec but there is a file related to analytics... I thought she will push the JSON but that also will be a problem for me if she does it...

The problem while running is its about SDK version to upgrade whereas in her system it's running very effectively, but I am unable to update the same in my system

Try upgrading SDK in pubspec.yaml to

sdk: ">=2.5.0 <3.0.0"

SAITARUN55 commented 4 years ago

@prasadsunny1 There is no JSON file and there are errors while running...she took the analytics from pubspec but there is a file related to analytics... I thought she will push the JSON but that also will be a problem for me if she does it...

The problem while running is its about SDK version to upgrade whereas in her system it's running very effectively, but I am unable to update the same in my system

Try upgrading SDK in pubspec.yaml to

sdk: ">=2.5.0 <3.0.0"

Did that also...but no use