This pull request proposes a more user-friendly deployment of the application. In this case, we no longer need to use additional variables, such as RUN_SAMA=true. This is now managed through the Docker Compose override development file.
It also seems that this section of the README is no longer needed:
:warning: If you are using MacOS or Windows, and want run `SAMA` apps, add these two variables before the launch command:
MacOS
MINIO_ENDPOINT=$(ipconfig getifaddr en0) MINIO_PORT=9010
Windows
$env:MINIO_ENDPOINT = (Get-NetIPAddress | Where-Object { $_.AddressFamily -eq 'IPv4' -and $_.IPAddress -match '^192\.168\.|^10\.|^172\.(1[6-9]|2[0-9]|3[0-1])\.' } | Select-Object -ExpandProperty IPAddress)[1]; $env:MINIO_PORT = 9010;
If you are encountering issues with attachments in the web client, it suggests that an error occurred in the first variable. To resolve this, you can simply update the code segment with the private IP address of your machine.
During testing on MacOS, it was not necessary to set these variables, so it should be checked on Windows.
It's also worth noting that I didn't change this part:
To build and run the `SAMA` with all dependencies, you can use the following command:
docker-compose -f docker-compose-full.yml up --build
I believe no variability is needed for this file.
Let me know if anything needs to be changed or improved.
This pull request proposes a more user-friendly deployment of the application. In this case, we no longer need to use additional variables, such as
RUN_SAMA=true. This is now managed through the Docker Compose override development file.It also seems that this section of the README is no longer needed:
During testing on MacOS, it was not necessary to set these variables, so it should be checked on Windows.
It's also worth noting that I didn't change this part:
I believe no variability is needed for this file. Let me know if anything needs to be changed or improved.