search

SAME-Project / same-project

https://sameproject.ml/
Apache License 2.0
20 stars 8 forks source link

various UX improvements #145

Closed lukemarsden closed 2 years ago

lukemarsden commented 2 years ago
lukemarsden commented 2 years ago

The API version is different to the CLI version

On Mon, 16 May 2022, 08:57 Guy Paterson-Jones, @.***> wrote:

@.**** commented on this pull request.

In sameproject/cli/init.py https://github.com/SAME-Project/same-project/pull/145#discussion_r873430081 :

def _get_api_version():

  • try:
  • return pkg_resources.get_distribution("sameproject").version
  • except Exception:
  • return "unknown" # TODO: better fallback
  • return "sameproject.ml/v1alpha1"

We should probably merge the logic here with the same version command.

— Reply to this email directly, view it on GitHub https://github.com/SAME-Project/same-project/pull/145#pullrequestreview-973544043, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACATUQIZYIPLNQU6KPBSVTVKH5XLANCNFSM5V3GKH7Q . You are receiving this because you authored the thread.Message ID: @.***>