Closed gohar94 closed 3 years ago
github-actions[bot]
commented
3 years ago 1 files 1 suites 29s :stopwatch: 47 tests 45 :heavy_check_mark: 2 :zzz: 0 :x:
Results for commit 75de460e.
:recycle: This comment has been updated with latest results.
aronchick
commented
3 years ago This is terrific - i can't believe you've already gotten it to work with my code! Just outstanding :)
But I wonder if there's another way to architect this that we should talk about - the way this is architected, it implies the CLI is the orchestrator, handing off jobs one at a time to AzF and coordinating. However, in the old model (https://github.com/azure-octo/same-cli/tree/main/static), we built templates to create and execute on alternate backends (kubeflow and AML to start). I think this latter model is the way we want to go - we don't want to rewrite yet another workflow engine.
So, in this case, imagine we took your code and, instead, built a way to describe a workflow on Azure Logic Apps (or something similar), and, inside that, we executed functions serially.
Does that make sense?
cc @rynowak @SAME-Project/same-team-core
gohar94
commented
3 years ago @aronchick How do you generate the root requirements.txt with the versions etc.?
gohar94
commented
3 years ago cc: @goiri
github-actions[bot]
commented
3 years ago 
Coverage Report
File Stmts Miss Cover cli/same init.py 0 0 100% helpers.py 0 0 100% main.py 11 11 0% mapping.py 1 0 100% same_config.py 54 13 76% stdlib.py 1 0 100% cli/same/program init.py 0 0 100% commands.py 15 1 93% cli/same/program/compile init.py 0 0 100% context.py 4 0 100% notebook_processing.py 98 9 91% cli/same/version init.py 0 0 100% commands.py 4 0 100% sdk setup.py 12 12 0% sdk/same init.py 1 0 100% _version.py 1 1 0% conda_env.py 47 11 77% core.py 1 1 0% helpers.py 0 0 100% importer.py 65 14 78% parallel.py 0 0 100% TOTAL 315 73 77%
| Tests | Skipped | Failures | Errors | Time |
|---|---|---|---|---|
| 47 | 2 :zzz: | 2 :x: | 0 :fire: | 19.236s :stopwatch: |
github-actions[bot]
commented
3 years ago 
Coverage Report
File Stmts Miss Cover backends init.py 0 0 100% backends/common init.py 0 0 100% code_executor.py 24 24 0% exception_utils.py 8 8 0% http_utils.py 16 16 0% serialization_utils.py 12 12 0% cli/same init.py 0 0 100% helpers.py 0 0 100% main.py 11 11 0% mapping.py 1 0 100% same_config.py 54 13 76% stdlib.py 1 0 100% cli/same/program init.py 0 0 100% commands.py 15 1 93% cli/same/program/compile init.py 0 0 100% context.py 4 0 100% notebook_processing.py 103 9 91% cli/same/version init.py 0 0 100% commands.py 4 0 100% objects init.py 0 0 100% json_serializable_object.py 28 10 64% step.py 26 5 81% sdk setup.py 12 12 0% sdk/same init.py 1 0 100% _version.py 1 1 0% conda_env.py 47 11 77% core.py 1 1 0% helpers.py 0 0 100% importer.py 65 6 91% parallel.py 0 0 100% TOTAL 434 140 68%
| Tests | Skipped | Failures | Errors | Time |
|---|---|---|---|---|
| 47 | 2 :zzz: | 0 :x: | 0 :fire: | 29.980s :stopwatch: |
Basic structure layed out for using Azure Functions and Durable Functions as a backend.