Closed annajung closed 2 years ago
added labels https://github.com/SAME-Project/same-project/labels/needs-ok-to-test & https://github.com/SAME-Project/same-project/labels/ok-to-test
@annajung wanna test this out?
hm, it broke https://github.com/SAME-Project/same-project/runs/5628253941?check_suite_focus=true, tried it fix it with: https://github.com/SAME-Project/same-project/commit/029793aaa516117f94320e0ca4fc2b759d95b4f4
but now: https://github.com/SAME-Project/same-project/runs/5628337705?check_suite_focus=true
@annajung any ideas?
Signed-off-by: Anna Jung (VMware) antheaj@vmware.com
fixes https://github.com/SAME-Project/same-project/issues/61
pull_request_target
to give write accessGITHUB_TOKEN
to forked reposneeds-ok-to-test
label for all PRs which requires vetting and labelok-to-test
to allow build/test workflow to triggerEven though the labeler workflow also is given
write
access to label the pull request, I think that's okay based on the blog post which mentions that it's the explicit checkout of an untrusted PR that's the dangerous practice:I also think that someone with access needs to create the two labels (
needs-ok-to-test
andok-to-test
) manually before the labels can be used in the workflow.