search

SAME-Project / same-project

https://sameproject.ml/
Apache License 2.0
20 stars 8 forks source link

Add YouTube link #87

Closed annajung closed 2 years ago

annajung commented 2 years ago

Signed-off-by: Anna Jung (VMware) antheaj@vmware.com

annajung commented 2 years ago

@lukemarsden Could you add ok-to-test label to test if the GitHub actions are working as expected? Looks like https://github.com/SAME-Project/same-project/pull/84 from @Bubblyworld might have fixed it.

annajung commented 2 years ago

Looks like it works as expected! Closing out the PR

Bubblyworld commented 2 years ago

@annajung one thing I noticed is that the build/test actions are running against the base branch, rather than the pull-request branch, is that the intention?

annajung commented 2 years ago

Thanks for pointing this out! That was not the intention and I was testing and debating on if ref should be added to the checkout step and somehow got totally missed it in the PR.

Do you have feedback on adding explicit PR checkout with pull_request_target? Or is there a better way to handle it without explicit target?

Bubblyworld commented 2 years ago

An explicit checkout sounds good to me, seems like what everyone does to get around this! Boy, github actions make it kinda hard to work with external PRs 😅

annajung commented 2 years ago

Yeah, that's where I ended up eventually as well! Thanks for the feedback! Made a PR for the fix https://github.com/SAME-Project/same-project/pull/90