search

SAML-Toolkits / java-saml

Java SAML toolkit
MIT License
631 stars 393 forks source link

Issues Javax EE to Jakarta EE using java-saml #419

Open jacqueskpoty opened 6 months ago

jacqueskpoty commented 6 months ago

It'is impossible to use java-saml with java 17 at this point. Is there any work around? is the community working on releasing a new version with java 17?

haavar commented 6 months ago

What's the issue with running under java 17?

jacqueskpoty commented 6 months ago

Since java 17 many of the classes in javax package are moved to jakarta. This is causing a big issue. I recently upgraded my project to Spring Boot 3.2.2 so im forced to use java 17 This upgrade makes java-saml unusable.

mauromol commented 6 months ago

Java 17 itself has nothing to do with the change from Java EE to Jakarta EE.

jacqueskpoty commented 6 months ago

Is there anything being done to support the change from Java EE to Jakarta EE for java-saml?

mauromol commented 6 months ago

There's PR #395 open.

jacqueskpoty commented 6 months ago

@mauromol Thanks. I checked and the PR has been for a year. Hopefully it will be merged soon.

william00179 commented 6 months ago

This package can be easily transformed with https://github.com/eclipse/transformer and then used.

I am using this for this package and many others that don't support the jakarta migration.

paulrutter commented 5 months ago

https://github.com/SAML-Toolkits/java-saml/issues/349#issuecomment-2020338432 is another workaround.

haavar commented 5 months ago

How are you guys using the servlet API with the SAML library? Can you not just pass in the parameters, instead of wrapping the request? I've been using jarkarta for a while now, and that did not affect how I used saml core.

paulrutter commented 5 months ago

Java-saml uses javax classes, java-saml-core does not. See https://github.com/SAML-Toolkits/java-saml#the-httprequest