SAML-Toolkits / java-saml

Java SAML toolkit
MIT License
634 stars 398 forks source link

jacoco // coveralls not working. #74

Closed pitbulk closed 8 years ago

pitbulk commented 8 years ago

It seems that on java 1.8 jacoco // coveralls fail.

mvn -v
Apache Maven 3.2.5
Java version: 1.8.0_91, vendor: Oracle Corporation

mvn clean test jacoco:report coveralls:report

No plugin found for prefix 'jacoco' in the current project and in the plugin groups
[org.apache.maven.plugins, org.codehaus.mojo] available from the repositories
[local (/home/xxx/.m2/repository), central (https://repo.maven.apache.org/maven2)]

No plugin found for prefix 'coveralls' in the current project and in the plugin groups
[org.apache.maven.plugins, org.codehaus.mojo] available from the repositories
[local (/home/xxx/.m2/repository), central (https://repo.maven.apache.org/maven2)]
pitbulk commented 8 years ago

It was solved adding the groupid info to the command: https://github.com/onelogin/java-saml/commit/87bfad85ba012a0bc0a87815156aefa3cdd87ca4

Now I'm getting:

[INFO] --- jacoco-maven-plugin:0.7.7.201606060606:report (default-cli) @ java-saml ---
[INFO] Skipping JaCoCo execution due to missing execution data file

[INFO] --- jacoco-maven-plugin:0.7.7.201606060606:report (default-cli) @ java-saml-tookit-jspsample ---
[INFO] Skipping JaCoCo execution due to missing execution data file.
pitbulk commented 8 years ago

Fixed by commenting

<properties>
                <jacoco.agent.argLine />
</properties>

from the pom.xml files. https://github.com/onelogin/java-saml/commit/df11a579100e7d38ca36f513fee599bb3a8ccee1

Described here: http://stackoverflow.com/questions/33293930/jacoco-not-generating-jacoco-exec-until-after-skipping-jacoco-execution