search

SAML-Toolkits / php-saml

Simple SAML toolkit for PHP
MIT License
1.22k stars 466 forks source link

Stop supporting EOL php 5 #364

Closed Hikariii closed 1 year ago

Hikariii commented 5 years ago

Relating to an older issue of me https://github.com/onelogin/php-saml/issues/59 I suggest to simplify different branches and move to php 7 for the master branch. Php5 is EOL and will not even receive security patches anymore.

http://php.net/supported-versions.php

pitbulk commented 5 years ago

Is true that PHP5.6 is not supported anymore, but there are tons of apps working with PHP5.X and not with PHP7.X.

That why I plan to maintain supporting PHP5.6 here.

I think point master to 3.X branch rather than 2.X is something that must be done, but not an imminent change because there are tons of integrations that could be pointing to master, expecting it 2.X and a change can break their environments.

ideaweb commented 5 years ago

Please note, Php5 EOL is announced by PHP team "only". I cannot believe that all distributions like Debian would become insecure from one day to another. I think if Debian e.g. Jessie is still supported till mid 2020, Debian team will maintain it with security fixes. The same is with Php70 too in Debian Etch where support is till 2022(!) but EOL was announced nearly together with Php56. If developers would remove support of php56 and php70 lot of websites running on Debian would have a huge problem.