search

SAML-Toolkits / php-saml

Simple SAML toolkit for PHP
MIT License
1.23k stars 469 forks source link

Compatibility with PHP 8.1 #525

Closed pitbulk closed 2 years ago

pitbulk commented 2 years ago

This changes add compatibility with PHP 8.1

If null param are provided to trim or preg_match, when PHP 8.1 has deprecation errors enabled, php-saml will raise errors.

pitbulk commented 2 years ago

@bzvestey Can you review, merge and release 4.0.1 ?

bzvestey commented 2 years ago

@pitbulk I will take a look tomorrow.

mrmoss commented 2 years ago

Code changes LGTM, but the tests are failing.

Also, Hi Sixto! 👋

pitbulk commented 2 years ago

Thanks @bzvestey

Hi @mrmoss fixed the tests, I had a typo

bzvestey commented 2 years ago

I will look into doing a release this week.

pitbulk commented 2 years ago

Thanks, appreciated

bzvestey commented 2 years ago

@pitbulk This has been released, let me know if there are any issues with it.

pitbulk commented 2 years ago

Great, thanks!

pitbulk commented 2 years ago

@bzvestey when doing a new release, you need to update the version.json file

I see 4.0.0 on the 4.0.1 release

https://github.com/onelogin/php-saml/blob/4.0.1/src/Saml2/version.json#L3

bzvestey commented 2 years ago

Ah, ok, I will fix this. Sorry about the delay, I have been in the middle of moving.

bzvestey commented 2 years ago

The version file should now be fixed.

Edited: to fix not to now...