SAML-Toolkits / php-saml

Simple SAML toolkit for PHP
MIT License
1.21k stars 462 forks source link

Conflicting versions #550

Open gweinfurther opened 1 year ago

gweinfurther commented 1 year ago

The files on the "Code" tab on the Github page are version 2.19.1, according to CHANGELOG. The class names do not use namespaces.

If I download the "master" package from Github, I get a file named php-saml-master.zip. This also contains version v.2.19.1 (according the CHANGELOG). The class names do not use namespaces. If I download using Git or Git Desktop, this is the file I get.

If I select the "Latest" button on the right side of the Github page, I get a file named php-saml-4.1.0.zip. It contains version v4.0.0 according to the CHANGELOG file. The class names use namespaces. There are no demo1, demo2, docs, endpoints, lib, or extlib folders included. This is also the version I get when I use composer.

This is very confusing and tripped me up when my code wouldn't work. Why does the Github page not include the correct version of the library? Why does the 4.1.0 package not include the demo1, demo2, docs, endpoints, lib, or extlib folders?

pitbulk commented 1 year ago

There are currently 3 active main branches:

The download the "master" package from Github will provide you a zip with the master branch, an exact copy of the files available on GitHub.

The link of the release page point to the latest release done which is v4.1.0

Releases does not include demos, are intended to be directly used on production. Similar behavior that if you install the extension via composer.