Fix: buildWithBaseURLPath corrupts the current route if it contains slashes, causing assertion validation to fail #249

SAML-Toolkits / php-saml

Simple SAML toolkit for PHP

MIT License

1.21k stars 462 forks source link

Open malekbig opened 1 year ago

malekbig commented 1 year ago

Fix buildWithBaseURLPath corrupts the current route if it contains slashes, causing assertion validation to fail

pitbulk commented 1 year ago

@malekbig It seems your fix breaks a test

joelpittet commented 3 months ago

Also the subdirectory now gets duplicated if you fix the argument issue with implode. https://3v4l.org/1qpDY

I'm trying to solve a similar issue with this function. The array_pop() assumes only one component path

joelpittet commented 3 months ago

This might fix it #581 and sounds like a dupe of #579