SAML-Toolkits / php-saml

Simple SAML toolkit for PHP
MIT License
1.21k stars 462 forks source link

Fixes #579 buildWithBaseURLPath return only last part of url #580

Closed joelpittet closed 3 months ago

joelpittet commented 3 months ago

The array_pop() assumes the last part of the path is the only valid leading an invalid_response error:

"The response was received at https://example.com/sub-directory/acs instead of https://example.com/sub-directory/saml/acs"

joelpittet commented 3 months ago

This should help fix #579

joelpittet commented 3 months ago

Closing this in favour of the 4.x-dev branch Created a PR over here https://github.com/SAML-Toolkits/php-saml/pull/581