Wrong destination URL for SP initiated Single Logout

SAML-Toolkits / python3-saml

MIT License

694 stars 309 forks source link

Wrong destination URL for SP initiated Single Logout #234

Closed nltommynl closed 3 years ago

nltommynl commented 3 years ago

Hi,

In 9fdb11d (which is included in v1.10.0), in addition to logout_response.py, logout_request.py has also been modified. This is incorrect and only the logout_response.py should point to a response URL. Now all logoutRequest and logoutResponse messages are sent to the slo response URL.

src/onelogin/saml2/logout_request.py:

'single_logout_url': self.__settings.get_idp_slo_response_url(),

Should be

'single_logout_url': self.__settings.get_idp_slo_url(),

nltommynl commented 3 years ago

I made a PR for this issue. @pitbulk do you see an opportunity to review/merge these?

pitbulk commented 3 years ago

Merged and 10.0.1 release.

Thanks for the catch