search

SAML-Toolkits / python3-saml

MIT License
683 stars 304 forks source link

Use the xacml/saml2 XSD #240

Closed flupzor closed 3 years ago

flupzor commented 3 years ago

The SAML service we use (eHerkenning) uses the xacml/saml profile (http://docs.oasis-open.org/xacml/xacml-saml-profile/v2.0/xacml-saml-profile-v2.0.html). In our implementation I replaced the XSDs with the saml/xacml ones, like I did below. However, I can understand if the preference would be to implement this otherwise. By making it configurable for example.

I can make a PR that would make the XSDs configurable, if that is something that would be preferred. I figured I discuss it before putting any effort into it.

pitbulk commented 3 years ago

I don't see this as part of the project, maybe as something that you can plug-in

Maybe add "saml-schema-protocol-2.0.xsd" and others definition as a constant on the Constant class and then in your scenario you only need to change 2 lines in constants.py file as well as drop all the xsds

flupzor commented 3 years ago

Thanks for the quick replies (on all PRs). I'll close this PR for now and will re-make a PR where I create something which can plugin to the existing code.