search

SAML-Toolkits / python3-saml

MIT License
682 stars 304 forks source link

Replace double-underscored names with single underscores #274

Closed akx closed 3 years ago

akx commented 3 years ago

This will avoid Python's class-name-prefix mangling of attributes and methods while still retaining the signal that they're meant for private use of the library.

This makes it easier to e.g. subclass classes should one need to (e.g. as I needed in #212), and to access data from outside (while being mindful of the fact that you're accessing notionally private data).

Only one change to a test was required (and that test was indeed accessing a private field from outside and had to jump through hoops 😄 ).

pitbulk commented 3 years ago

WIll consider this change for a future release.