search

SAML-Toolkits / python3-saml

MIT License
682 stars 304 forks source link

Python 3.10 support #294

Closed mbk4 closed 2 years ago

mbk4 commented 2 years ago

Hello, is Python 3.10 planned to be officially supported?

pitbulk commented 2 years ago

The build failed with the following error:

ile "/opt/hostedtoolcache/Python/3.10.2/x64/lib/python3.10/site-packages/setuptools/command/bdist_wininst.py", line 1, in <module>
        import distutils.command.bdist_wininst as orig
    ModuleNotFoundError: No module named 'distutils.command.bdist_wininst'

Ref: https://docs.python.org/3.10/whatsnew/3.10.html#distutils

Not sure how to fix that atm.

akx commented 2 years ago

I can take a look. I think it's just an outdated setuptools...

EDIT: Yep, that was it. For some reason the Makefile forcibly downgrades Setuptools to an incompatible version: https://github.com/onelogin/python3-saml/blob/dc05f2bec590088e54d88f78af78034bb0f1c6c0/Makefile#L14

This is fixed in #298.