search

SAML-Toolkits / python3-saml

MIT License
682 stars 304 forks source link

Don't require yanked version of lxml #297

Closed akx closed 2 years ago

akx commented 2 years ago

Version 4.7.0 of lxml was yanked from pypi because it was missing some required data.

Version 4.7.1 replaces it; changing the specifier from == to ~= allows any 4.7.x series lxml.

EDIT: I just saw #292 / a55cc9a379da03eff9f96a886f6164fd0792a62e ... has this been reported upstream to lxml?

pitbulk commented 2 years ago

In that case i prefer lxml<4.7.1

@bzvestey a new python3-saml release should be done including the 2 PRs recently approved and the change with lxml<4.7.1

@akx I believe the bug was introduced by https://github.com/lxml/lxml/pull/332

bzvestey commented 2 years ago

@eriktalvi FYI

pitbulk commented 2 years ago

@eriktalvi any ETA for solving this? It is impacting some customers.

eriktalvi commented 2 years ago

Going with @pitbulk's suggestion. There was an issue with 4.7.1 that I don't want to reintroduce without fixing.

bzvestey commented 2 years ago

This have been release as part of version 1.14.0

tkdchen commented 2 years ago

@pitbulk Hello, why https://github.com/lxml/lxml/pull/332 introduced the bug? IIUC, the final result of this pr is just to add a few tests. Anything I missed?