search

SAML-Toolkits / python3-saml

MIT License
704 stars 309 forks source link

test: Add test for encrypted attributes #370

Closed AbdealiLoKo closed 1 year ago

AbdealiLoKo commented 1 year ago

When using lxml 4.5.2 - the testcases PASS When using lxml 4.6.5 - the testcases PASS When using lxml 4.7.1 - the testcases FAIL When using lxml 4.8.0 - the testcases FAIL When using lxml 4.9.3 - the testcases FAIL

This is a testcase I have written for https://github.com/SAML-Toolkits/python3-saml/issues/343 Seems like python3-saml decryption only works with older versions of lxml

pitbulk commented 1 year ago

Added the test here https://github.com/SAML-Toolkits/python3-saml/commit/28b753e9a7ee1da78801170791e0a9724014f360

You can see on this CI result that the test pass with lxml 4.9.3 https://github.com/SAML-Toolkits/python3-saml/actions/runs/6454855240/job/17521370691

AbdealiLoKo commented 1 year ago

Thanks for the merge @pitbulk Could you point me to which commit fixes the actual issue though ? I went through commit history and couldn't find a commit which would make this test case work