search

SAML-Toolkits / python3-saml

MIT License
688 stars 305 forks source link

Apply clock drift to SubjectConfirmationData and AuthnStatement #385

Closed tvuotila closed 3 days ago

tvuotila commented 11 months ago

I was debugging SAML response with arbitrarily large ALLOWED_CLOCK_DRIFT. I noticed that it didn't apply to all timestamp values. This PR makes the ALLOWED_CLOCK_DRIFT to apply to more values.

Should I add some tests for this? What kind of tests are needed?

tvuotila commented 3 months ago

@pitbulk Can this be merged?

tvuotila commented 1 month ago

@pitbulk Can this be merged?