introduce custom filenames for idp/sp cert/key

do9xe commented 4 months ago

This PR introduces the possibility to have custom filenames for the service provider certificate and key, as well for the IdP cert.

Background When deploying code in production environments it is common to have a dedicated folder for certificates. Especially if a server is hosting several services this folder also can contain several certificates. Having a custom filename enhances usability for administrators and gives the user more flexibility.

about this PR

I introduced three new methods to the settings object class to set the custom filenames
I had to change the order of the code in _load_settings_dict(), because it doesn't matter if we check the config before or after copying it to the protected attributes. Also, this became necessary as the protected attributes are called during config check.
I added the default values for the filenames
This closes #392
I added some tests in order to test against a custom filename and a non-existing filename

Tests I ran all tests and all relevant tests passed, except for two of them, but reason for this is Windows using a different path separator and I didn't want to change the tests also.

do9xe commented 4 months ago

Any further comments or can we merge this?

do9xe commented 3 months ago

What's the status here? Can this be merged or does this patch need some additional work?

SAML-Toolkits / python3-saml

introduce custom filenames for idp/sp cert/key #395