search

SAML-Toolkits / python3-saml

MIT License
699 stars 309 forks source link

NameIDFormat - PascalCase? #402

Open eljeffeg opened 7 months ago

eljeffeg commented 7 months ago

So every setting key name is CamelCase except NameIDFormat. Is there a particular reason for this? I'm building a connector and due to ES, the settings need to be snake_case: https://www.elastic.co/guide/en/ecs/current/ecs-guidelines.html#_guidelines_for_field_names

So I have to convert them all from snake case to camel case for python3-saml, but for one exception that doesn't follow the rule. Anyway.. figured I'd grumble. haha

eljeffeg commented 7 months ago

And the organization country codes en-US, Kebab Case? 🤦

pitbulk commented 4 months ago

I think I can fix that and support both NameIDFormat and NameIdFormat.

And related to the use of 'en-US' as country code, I see its use in many many places, for example see this page where Metadata elements are described, it uses 'en-US'

but you can use whatever lang code as part of the info for the Organizational Data you inject in your settings.