Allow passing in timeout/retry settings to Net::HTTP

SAML-Toolkits / ruby-saml

SAML SSO for Ruby

https://developers.onelogin.com/v1.0/page/saml-toolkit-for-ruby-on-rails

MIT License

898 stars 561 forks source link

Allow passing in timeout/retry settings to Net::HTTP #677

Open tjschuck opened 4 months ago

tjschuck commented 4 months ago

When fetching remote XML files from arbitrary URLs, you might want to configure different values for timeouts/retries to avoid allowing users to DoS you via intentionally slow endpoints. The Net::HTTP defaults are 60 seconds plus 1 retry, which could easily deplete resources if intentionally exploited.

tjschuck commented 3 months ago

Just bumping this — @pitbulk anything I can do to help get this merged and shipped?